Fix #2230, default identifier renaming issue #2234
Conversation
|
If we could get a release with this change soon, it will save our team a lot of time :) |
|
@diervo you're welcome. Shameless plug - Salesforce OS support would look great at https://opencollective.com/rollup :) I don't have publish access, but @lukastaegert should be back today, so we should be able to get this out early this week. |
|
@guybedford @lukastaegert Yes! I'm working on it ;) I just got approval for babel last month (https://opencollective.com/salesforce), and I'm working for getting rollup as well, keep you updated. Thanks for the quick turn around. |
|
@diervo that would be amazing, thank you so much for looking into it! |
| console.log('effect'); | ||
| a = someGlobal; | ||
| return a(); | ||
| } |
There was a problem hiding this comment.
I would remove the console.log statement as the function call should not be removed even without it. a() is basically equivalent to someGlobal() which can have side-effects.
| this.name = identifier.name; | ||
| if (this.original !== null) { | ||
| this.original.addReference(identifier); | ||
| } |
There was a problem hiding this comment.
Seems like a good approach! The original logic was probably only in place to provide a better name than the file name to unnamed default exports. If we have an id, using that makes a lot of sense.
lukastaegert
force-pushed
the
default-identifier-handling
branch
from
06b6204
to
9fbf06a
Compare
|
jajaja! Dinner is on me! |
This ensures that the name of the default variable is kept as its declaration name for function and class declarations, instead of using reference hints.