New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test that errors are passed to the buildEnd hook #2450

Merged

lukastaegert merged 2 commits into master from test-error-in-build-end

Sep 16, 2018

Member

lukastaegert commented Sep 10, 2018

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:
Resolves #2449

Description

Errors were not handed to the buildEnd hook due to typing errors. The actual fix was part of #2438, this just adds a test.


          Test that errors are passed to the buildEnd hook

ca39e01

lukastaegert mentioned this pull request

buildEnd doesn't pass error in argument anymore since 0.65 #2449

Closed


          Merge branch 'master' into test-error-in-build-end

1e7d114

lukastaegert merged commit 138033e into master

lukastaegert deleted the test-error-in-build-end branch

September 16, 2018 05:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment