Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: experimentalPreserveModules not support in inlineDynamicImports … #2560

Merged
merged 2 commits into from
Nov 17, 2018
Merged

fix: experimentalPreserveModules not support in inlineDynamicImports … #2560

merged 2 commits into from
Nov 17, 2018

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Nov 16, 2018 •
edited by lukastaegert

…message

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Since inlineDynamicImports won't be truthy in else if (inputOptions.experimentalPreserveModules), so move INVALID_OPTION above.

lukastaegert
lukastaegert approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Usually I would ask for a test as this was broken before but since this is subject to be refactored in 1.0 anyway, I will as an exception merge this as it is.

@lukastaegert lukastaegert merged commit 084354e into rollup:master Nov 17, 2018
This was referenced Aug 31, 2019
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 6, 2020
Open
This was referenced Mar 25, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clarkdo @lukastaegert