Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely omit files that do not have any included statements #2940

Merged
merged 1 commit into from Jun 14, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jun 14, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2927

Description

Previously even files where all statements were tree-shaken had their banner and footer comments included. This PR changes this so that files without included statements

  • are not rendered internally for better performance
  • are completely omitted from the generated code including all comments
  • can be safely detected by checking for renderedLength === 0 in the modules property of chunks in the generated bundle

@lukastaegert lukastaegert force-pushed the gh-2927-completely-treeshake-files branch from 43d3f3d to ebeddc1 Compare Jun 14, 2019
@lukastaegert lukastaegert merged commit b216023 into master Jun 14, 2019
4 of 6 checks passed
@lukastaegert lukastaegert deleted the gh-2927-completely-treeshake-files branch Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant