Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid variable from empty module name be empty #3026

merged 8 commits into from Aug 5, 2019

Avoid variable from empty module name be empty #3026

merged 8 commits into from Aug 5, 2019


Copy link

@LongTengDao LongTengDao commented Aug 5, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Avoid to generate below when options.input is empty string:

'use strict';

var  = 0;

module.exports = ;
@LongTengDao LongTengDao marked this pull request as ready for review Aug 5, 2019
Copy link

@codecov codecov bot commented Aug 5, 2019

Codecov Report

No coverage uploaded for pull request base (master@17eaa43). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3026   +/-   ##
  Coverage          ?   88.65%           
  Files             ?      165           
  Lines             ?     5696           
  Branches          ?     1739           
  Hits              ?     5050           
  Misses            ?      388           
  Partials          ?      258
Impacted Files Coverage Δ
src/utils/identifierHelpers.ts 83.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eaa43...cc90184. Read the comment docs.

Copy link

@lukastaegert lukastaegert left a comment

Looks good!

@lukastaegert lukastaegert merged commit 456f4d2 into rollup:master Aug 5, 2019
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants