Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist/bin/** to published files #3032

Closed
wants to merge 1 commit into from
Closed

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Aug 5, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Follow up to #3031

Fixes #3029

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #3032 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3032   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         165      165           
  Lines        5694     5694           
  Branches     1738     1738           
=======================================
  Hits         5048     5048           
  Misses        388      388           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c4869...c57a1fc. Read the comment docs.

@lukastaegert
Copy link
Member

Thanks, sorry, did the fix directly on master, hope it works now?

@styfle
Copy link
Contributor Author

styfle commented Aug 5, 2019

@lukastaegert Yes it works now, thanks

@styfle styfle closed this Aug 5, 2019
@styfle styfle deleted the patch-1 branch August 5, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ERR! enoent ENOENT: no such file or directory, rollup/dist/bin/rollup.js
5 participants