Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not ready for merge
This enables #30, and by extension #25 (eventually), by applying the
resolvePath
hook tooptions.entry
.resolvePath
is now a misnomer; it should becomeresolveId
or something similar, and there are a few other bits of internal terminology that will probably need updating as well.Something to note:
bundle.entryPath
andbundle.base
no longer exist. These were used for the purposes of generating non-conflicting identifiers by restricting the 'available' path parts to those within the source directory (i.e._foo
to deconflict withfoo
, rather thanUsers_rharris_code_someProject_src_foo
) - for now, that's being worked around, but it'll need a more robust approach eventually.bundle.base