Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly specify type of writeBundle hook in docs #3441

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Correctly specify type of writeBundle hook in docs #3441

merged 1 commit into from
Mar 13, 2020

Conversation

danimoh
Copy link
Contributor

@danimoh danimoh commented Mar 13, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
None

Description

In contrary to the documentation, the writeBundle hook for plugins is apparently called with two arguments, the first being the OutputOptions and the second the bundle.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #3441 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3441   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         171      171           
  Lines        5841     5841           
  Branches     1723     1723           
=======================================
  Hits         5550     5550           
  Misses        157      157           
  Partials      134      134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b73e4...ccb75d3. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how we could miss that 🙄

@lukastaegert lukastaegert merged commit e019ea0 into rollup:master Mar 13, 2020
@danimoh danimoh deleted the fix-docs-write-bundle branch March 13, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants