Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle side-effects next to side-effect-free default exports in case the default export is reexported #3602

Merged
merged 1 commit into from
May 28, 2020
Merged

Handle side-effects next to side-effect-free default exports in case the default export is reexported #3602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,8 @@ export default class Module {
getDependenciesToBeIncluded(): Set<Module | ExternalModule> {
if (this.relevantDependencies) return this.relevantDependencies;
const relevantDependencies = new Set<Module | ExternalModule>();
const additionalSideEffectModules = new Set();
const additionalSideEffectModules = new Set<Module>();
const possibleDependencies = new Set(this.dependencies);
let dependencyVariables = this.imports;
if (
this.isEntryPoint ||
Expand All @@ -350,15 +351,17 @@ export default class Module {
variable = original;
for (const module of modules) {
additionalSideEffectModules.add(module);
possibleDependencies.add(module);
}
}
relevantDependencies.add(variable.module!);
}
if (this.options.treeshake) {
const possibleDependencies = new Set(this.dependencies);
for (const dependency of possibleDependencies) {
if (
!(dependency.moduleSideEffects || additionalSideEffectModules.has(dependency)) ||
!(
dependency.moduleSideEffects || additionalSideEffectModules.has(dependency as Module)
) ||
relevantDependencies.has(dependency)
) {
continue;
Expand Down
1 change: 1 addition & 0 deletions test/form/samples/side-effect-default-reexport/default-export/reexport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as Menu } from './index';
3 changes: 1 addition & 2 deletions test/form/samples/side-effect-default-reexport/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import DefaultExport from './default-export/index.js';
import { Menu as DefaultExport } from './default-export/reexport.js';
console.log('test-package-default-export', DefaultExport.Item);

import { Menu as NamedExport } from './named-export/index.js';
console.log('test-package-named-export', NamedExport.Item);

export { default } from './default-export2/index.js';