Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass external config option through to rollup.rollup #417

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Pass external config option through to rollup.rollup #417

merged 1 commit into from
Jan 4, 2016

Conversation

Victorystick
Copy link
Contributor 

export default {
  entry: ...,
  external: [ 'yo', 'foo' ] // these have been ignored so far
};

Victorystick added a commit that referenced this pull request Jan 4, 2016
@Victorystick
Force ids specified in external to actually _be_ external.
0b92d51 
Fixes #410
Builds on top of #417
@Victorystick Victorystick mentioned this pull request Jan 4, 2016
Merged
Rich-Harris added a commit that referenced this pull request Jan 4, 2016
@Rich-Harris
Merge pull request #417 from rollup/pass-external-through
de32fbd 
Pass external config option through to `rollup.rollup`
@Rich-Harris Rich-Harris merged commit de32fbd into master Jan 4, 2016
@Rich-Harris Rich-Harris deleted the pass-external-through branch January 4, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Victorystick @Rich-Harris