Skip dead branches of a conditional expression. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows replacement of inline conditions such as in `export const resolve = isWindows ? win32Resolve : posixResolve;`.
|
@eventualbuddha This looks great! Are you reimplementing Node's |
|
@Victorystick yes, exactly. I'll share once I get this merged and tested out. The only thing I'm not sure of how to handle is how to trigger the inlining of |
Rich-Harris
added a commit
that referenced
this pull request
Jan 31, 2016
…branches Skip dead branches of a conditional expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows replacement of inline conditions such as in
export const resolve = isWindows ? win32Resolve : posixResolve;.