Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support export { global } #472

Merged
merged 4 commits into from
Jan 31, 2016
Merged

Support export { global } #472

merged 4 commits into from
Jan 31, 2016

Conversation

Victorystick
Copy link
Contributor

I encountered an error when attempting to export a global variable, like so:

export { Promise };
TypeError: Cannot set property 'isExported' of null
  ...

Rollup requires each exported binding to have a corresponding Declaration. This PR introduces a SyntheticGlobalDeclaration to circumvent this problem.

Rich-Harris added a commit that referenced this pull request Jan 31, 2016
@Rich-Harris Rich-Harris merged commit 51a87a8 into master Jan 31, 2016
@Rich-Harris Rich-Harris deleted the export-global branch January 31, 2016 19:01
@Rich-Harris
Copy link
Contributor

nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants