Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the type of RenderedModule.code is readonly #5091

Merged
merged 2 commits into from Aug 9, 2023
Merged

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Aug 8, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5081

Description

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:15am

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-5081

or load it into the REPL:
https://rollup-rh4qhxvul-rollup-js.vercel.app/repl/?pr=5091

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much ❤️

@lukastaegert lukastaegert merged commit 5559c5c into master Aug 9, 2023
10 checks passed
@lukastaegert lukastaegert deleted the fix-5081 branch August 9, 2023 05:27
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.28.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderedModule.code should be readonly in TypeScript declaration
3 participants