Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deoptimize custom event detail #5123

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This deoptimizes the detail property of custom events as that can be mutated later.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Sep 5, 2023 6:54pm

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5122-custom-event-detail

or load it into the REPL:
https://rollup-1dby30tni-rollup-js.vercel.app/repl/?pr=5123

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #5123 (b4483bf) into master (bb6bfa7) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5123   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         226      226           
  Lines        8394     8395    +1     
  Branches     2303     2303           
=======================================
+ Hits         8307     8308    +1     
  Misses         31       31           
  Partials       56       56           
Files Changed Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 100.00% <100.00%> (ø)

@lukastaegert lukastaegert merged commit 884e678 into master Sep 6, 2023
12 checks passed
@lukastaegert lukastaegert deleted the gh-5122-custom-event-detail branch September 6, 2023 05:27
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.29.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect treeshaking when passing detail to global CustomEvent
2 participants