Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error highlight in REPL #5219

Merged
merged 1 commit into from Oct 21, 2023
Merged

Fix error highlight in REPL #5219

merged 1 commit into from Oct 21, 2023

Conversation

lukastaegert
Copy link
Member

Also fix a type issue

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The syntax error highlighting in the REPL has been broken for some time due to a path issue, which is fixed here.

Also fix a type issue
@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 5:14am

@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-repl-error-highlight

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-9lnuq888x-rollup-js.vercel.app/repl/?pr=5219

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #5219 (71be109) into master (2bb2a64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5219   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         231      231           
  Lines        8849     8849           
  Branches     2314     2314           
=======================================
  Hits         8745     8745           
  Misses         43       43           
  Partials       61       61           

@lukastaegert lukastaegert merged commit 6a9d69e into master Oct 21, 2023
27 checks passed
@lukastaegert lukastaegert deleted the fix-repl-error-highlight branch October 21, 2023 11:24
@github-actions
Copy link

This PR has been released as part of rollup@4.1.5. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant