-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handling number key #5328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5328 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 8981 8983 +2
Branches 2341 2342 +1
=======================================
+ Hits 8875 8877 +2
Misses 46 46
Partials 60 60 ☔ View full report in Codecov by Sentry. |
@lukastaegert Ready to merge :) Sorry for holding onto these details. As a framework author, I cannot avoid problems by paying attention and avoiding using these edge cases myself. I must ensure the correctness of any upstream or downstream results. |
This PR has been released as part of rollup@4.9.4. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
https://rollupjs.org/repl/?version=4.9.2&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMColMjBhcyUyMHglMjBmcm9tJTIwJy4lMkZ4JyUzQiU1Q25jb25zb2xlLmxvZyh4KSUzQiU1Q24lMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTJDJTdCJTIyY29kZSUyMiUzQSUyMmV4cG9ydCUyMCU3QiUyMCcwMCclMkMlMjAnOTAwNzE5OTI1NDc0MDk5MyclMjAlN0QlMjBmcm9tJTIwJ3gnJTNCJTVDbiUyMiUyQyUyMmlzRW50cnklMjIlM0FmYWxzZSUyQyUyMm5hbWUlMjIlM0ElMjJ4LmpzJTIyJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMm91dHB1dCUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmVzJTIyJTdEJTJDJTIydHJlZXNoYWtlJTIyJTNBdHJ1ZSU3RCU3RA==