Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: static link msvc runtime on Windows x64 platform #5335

Merged
merged 1 commit into from Jan 11, 2024

Conversation

Brooooooklyn
Copy link
Contributor

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 8:31am

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, let's hope this really fixes things!

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1837203) 98.81% compared to head (6874c91) 98.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5335   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        8983     8983           
  Branches     2342     2342           
=======================================
  Hits         8877     8877           
  Misses         46       46           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue Jan 11, 2024
Merged via the queue into rollup:master with commit e37b05c Jan 11, 2024
28 checks passed
Copy link

This PR has been released as part of rollup@4.9.5. You can test it via npm install rollup.

@thewh1teagle
Copy link

@Brooooooklyn

User@Desktop UCRT64 ~/
$ npx rollup
Need to install the following packages:
  rollup@4.9.5
Ok to proceed? (y) y
thread '<unnamed>' panicked at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\napi-sys-2.3.0\src\functions.rs:7:3:
Must load N-API bindings
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Kreijstal
Copy link

ahh this might depend on wasm-pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on msys2 environment Cannot find module @rollup/rollup-win - nuxt 3 - npm install fail
4 participants