-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "output.hashCharacters" option to define character set for file hashes #5371
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5362_hash_characters Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5371 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 8997 9007 +10
Branches 2347 2350 +3
=======================================
+ Hits 8890 8900 +10
Misses 46 46
Partials 61 61 ☔ View full report in Codecov by Sentry. |
b63da96
to
7b05882
Compare
The hashes changed due to how they are now encoded
7b05882
to
9e5dd8e
Compare
This PR has been released as part of rollup@4.10.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds a new option
output.hashCharacters
that can take one of "hex", "base36" and "base64".This should mainly help people who struggle with the use of upper- and lower-case letters.
Note that this changes all current file hashes as the base64 conversion is done in a slightly different way.