-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve all rollup imports to node_modules to avoid type conflict #5386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix/build-xiaopi Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5386 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 232 232
Lines 9009 9009
Branches 2351 2351
=======================================
Hits 8902 8902
Misses 46 46
Partials 61 61 ☔ View full report in Codecov by Sentry. |
@lukastaegert I hope this PR can fix the current build problem. |
5101ee6
to
8fecd35
Compare
I think in the end, the problem was just the removal of skipLibCheck, but the other changes are welcome as well |
e9187da
to
e466d56
Compare
This PR has been released as part of rollup@4.10.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description