Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct base32 to base36 in documentation #5521

Merged
merged 1 commit into from
May 22, 2024

Conversation

highcastlee
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I am submitting a pull request to correct a typographical error in the configuration options documentation. The description of the output.hashCharacters option incorrectly states "base32" instead of "base36".

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:11pm

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, well-spotted!

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (a25a779) to head (3b4abf6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5521   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9540     9540           
  Branches     2437     2437           
=======================================
  Hits         9427     9427           
  Misses         48       48           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert added this pull request to the merge queue May 22, 2024
Merged via the queue into rollup:master with commit 13d8c99 May 22, 2024
38 checks passed
Copy link

This PR has been released as part of rollup@4.18.0. You can test it via npm install rollup.

@highcastlee highcastlee deleted the docs/base36-typo branch May 27, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants