Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows... #586

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Windows... #586

merged 1 commit into from
Apr 3, 2016

Conversation

MartinKolarik
Copy link
Contributor

Just spent about three hours trying to find out why some Ractive tests are failing for me and passing on Travis... Eventually I found out rollup was including the whole Ractive code twice in one file, which caused some instanceof checks to fail... Luckily, after identifying it was a problem with rollup, I found the offending code in two minutes 😄

@TrySound
Copy link
Member

TrySound commented Apr 3, 2016

@MartinKolarik Hi. Thanks. Can you rename commit more descriptive?

@MartinKolarik
Copy link
Contributor Author

yeah, sorry 😄

@Rich-Harris Rich-Harris merged commit 0fd8a87 into rollup:master Apr 3, 2016
@Rich-Harris
Copy link
Contributor

Thanks @MartinKolarik – released 0.25.8

@MartinKolarik
Copy link
Contributor Author

@Rich-Harris thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants