Build/bundle CLI #706
Merged
Build/bundle CLI #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,3 +7,4 @@ _actual | |||
| coverage | |||
| .commithash | |||
| .idea | |||
| bin/rollup | |||
There was a problem hiding this comment.
oops! done, thanks
| import { resolve } from 'path'; | ||
| import relative from 'require-relative'; | ||
| import handleError from './handleError'; | ||
| import SOURCEMAPPING_URL from './sourceMappingURL.js'; |
|
Didn't know where to ask this but at the source. :-) @Rich-Harris curious about this line. Why can't we import? https://github.com/rollup/rollup/blame/master/bin/src/runRollup.js#L6 |
|
@snuggs IIRC it's because things used to get terribly confusing if you had an import that was relative to the output bundle – Rollup would try and resolve it relative to the source file and all hell would break loose (but if the import was relative to the source file, the |
Rich-Harris
added a commit
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #700