Leave it up to resolveId to normalize the entry path.

[lemmabit]

Normalizing the entry ID before passing it to any plugins is redundant, because if it's a path, it will be normalized in resolveId like any other ID. If it isn't a path, normalizing it before passing it to resolveId may mangle it in a surprising way, such as by replacing backslashes with forward slashes.

[TrySound]

@Permutatrix Surprising test? :)

[lemmabit]

You mean like this? That test fails without this PR and succeeds with it. Or do you want me to add a new test to the PR?

[TrySound]

Yep, in the PR. We should prevent accidental adding it again.

[lemmabit]

Alright, there you go. Are tests a requirement for every PR?

[TrySound]

@Permutatrix If it modifies functionality, yes. Can this PR break something? I mean should I publish middle version?

[lemmabit]

@TrySound It's a long shot, but there could be a very poorly configured setup out there somewhere that looks something like this:

// rollup.config.js
import hypothetical from 'rollup-plugin-hypothetical';

export default {
  entry: 'x\\y',
  plugins: [hypothetical({
    files: {
      'x/y': `
        console.log("What a contrived example!");
      `
    },
    leaveIdsAlone: true
  })]
};

Any change that fixes behavior has the potential to break things that relied on the incorrect behavior, though. I wouldn't bump the minor version number for this myself, but it's obviously up to you.

[TrySound]

Thanks.

[TrySound]

0.34.7