Fixes #20
Fixes #20
Conversation
galkin
commented
Jan 2, 2017
galkin
commented
- Move missed MissingEnvVarsError function to index file (Missed file MissingEnvVarsError.js in 4.0.0 version during install #19)
- Fix inconsistent tests
- Add eslint for code style checks
| @@ -2,56 +2,80 @@ | |||
|
|
|||
| var dotenv = require('dotenv'); | |||
| var fs = require('fs'); | |||
| var MissingEnvVarsError = require('./MissingEnvVarsError.js'); | |||
| var util = require('util'); | |||
| function MissingEnvVarsError(allowEmptyValues, dotenvFilename, sampleFilename, missingVars, error) { | |||
There was a problem hiding this comment.
This error type should be in its own file. We can solve this by adding "MissingEnvVarsError.js" to the files array of package.json.
| 'no-var': 0, | ||
| 'max-len': [2, { | ||
| code: 120, | ||
| tabWidth: 2, |
There was a problem hiding this comment.
Sorry, 4 space tab width is intended here :)
Please use the following settings which also avoid an eslint plugin install (2 errors about comma-dangle in current master commit):
module.exports = {
"extends": "eslint:recommended",
"env": {
"node": true,
"mocha": true
},
"rules": {
"no-trailing-spaces": "error",
"semi": "error",
"indent": ["error", 4],
"comma-dangle": ["error", "never"]
}
};| "test": "mocha" | ||
| }, | ||
| "dependencies": { | ||
| "dotenv": "github:motdotla/dotenv#fdd0923e82e12a6e29b65898990201857141e75d" | ||
| }, | ||
| "devDependencies": { | ||
| "chai": "^3.5.0", | ||
| "eslint": "^3.12.2", | ||
| "eslint-config-google": "^0.7.1", |
There was a problem hiding this comment.
This should be removed in favor of eslint:recommended
|
|
||
| [*] | ||
| indent_style = space | ||
| indent_size = 2 |
There was a problem hiding this comment.
Please update .editorconfig to match comment in .eslintrc.js.
| @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [4.0.1] - 2017-01-03 | |||
| ### Changed | |||
| - Move missed MissingEnvVarsError function to index file | |||
There was a problem hiding this comment.
This should be:
### Fixed
- Fix missing `MissingEnvVarsError.js` error when calling `load()`
| ## [4.0.1] - 2017-01-03 | ||
| ### Changed | ||
| - Move missed MissingEnvVarsError function to index file | ||
| - Fix inconsistent tests |
There was a problem hiding this comment.
Not user facing, shouldn't be in changelog.
| ### Changed | ||
| - Move missed MissingEnvVarsError function to index file | ||
| - Fix inconsistent tests | ||
| - Add eslint for code style checks |
There was a problem hiding this comment.
Not user facing, shouldn't be in changelog.
| "keywords": [ | ||
| "dotenv" | ||
| ], | ||
| "license": "MIT", | ||
| "author": "Rodrigo López Dato <rlopezdato@gmail.com>", | ||
| "files": [ | ||
| "index.js", | ||
| "config.js" |
There was a problem hiding this comment.
"MissingEnvVarsError.js" should be added here
|
Closed as outdated. |
