-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7.1 Upgrade Causes map_with To Throw ArgumentError #691
Labels
Comments
flash-gordon
added a commit
that referenced
this issue
May 6, 2024
flash-gordon
added a commit
that referenced
this issue
May 6, 2024
Fix using .with on composite relations (fix #691)
flash-gordon
added a commit
that referenced
this issue
May 6, 2024
Thanks for reporting, it was fixed in 5.3.2, please check it out |
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Using rom-core 5.3.1, rails 7.1.3.2
The map_with interface in the relationship.rb file breaks when running rails 7.1+ but works fine on rails 7.0.
Error given:
ArgumentError: wrong number of arguments (given 1, expected 0)
To Reproduce
Create a basic mapping:
Note .by_pk and .one are not a factor.
Expected behavior
I expect map_with to work as it does when running rails 7.0. I've downgraded and upgraded and the only difference is the rails upgrade.
My environment
The text was updated successfully, but these errors were encountered: