chore: fix http parsing in case a full request was not sent #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
to dragonflydb/dragonfly
that referenced
this pull request
Apr 8, 2024
…c auth And thanks to @sunneydev for finding the bug and providing the tests. The tests actually uncovered another bug where we may parse partial http requests. This one is handled by romange/helio#243 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
chakaz
reviewed
Apr 8, 2024
chakaz
approved these changes
Apr 8, 2024
romange
added a commit
to dragonflydb/dragonfly
that referenced
this pull request
Apr 8, 2024
The assumption is that basic-auth already covers the authentication part. And thanks to @sunneydev for finding the bug and providing the tests. The tests actually uncovered another bug where we may parse partial http requests. This one is handled by romange/helio#243 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
to dragonflydb/dragonfly
that referenced
this pull request
Apr 8, 2024
fix: authorize the http connection to call DF commands The assumption is that basic-auth already covers the authentication part. And thanks to @sunneydev for finding the bug and providing the tests. The tests actually uncovered another bug where we may parse partial http requests. This one is handled by romange/helio#243 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
to dragonflydb/dragonfly
that referenced
this pull request
Apr 8, 2024
fix: authorize the http connection to call DF commands The assumption is that basic-auth already covers the authentication part. And thanks to @sunneydev for finding the bug and providing the tests. The tests actually uncovered another bug where we may parse partial http requests. This one is handled by romange/helio#243 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.