Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure all l10n keys are defined in en.ts #455

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tukusejssirs
Copy link
Member

@tukusejssirs tukusejssirs commented Aug 31, 2023

Changes:

  • fix(la): rename mary_of_jesus_in_the_blessed_sacrament_venegas_virgin to mary_of_jesus_in_the_blessed_sacrament_venegas_de_la_torre_virgin;
  • test(l10n): add a unit test to check if all names l10n keys defined in non-English locales, are also defined in en.ts.

…n` to `mary_of_jesus_in_the_blessed_sacrament_venegas_de_la_torre_virgin`
… in non-English locales, are also defined in `en.ts`
@tukusejssirs tukusejssirs added the concept: localization Anything related to localisation, i18n, locale keys... label Aug 31, 2023
@tukusejssirs tukusejssirs added this to the romcal v3.0 milestone Aug 31, 2023
@tukusejssirs tukusejssirs self-assigned this Aug 31, 2023
@tukusejssirs
Copy link
Member Author

TODO before making taking this PR out of WIP status:

After merging this PR, I want to port the changes to optimizations-ex in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept: localization Anything related to localisation, i18n, locale keys...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant