📎 Use the workspace to define internal crate dependencies

[ematipico]

Description

At the moment, in our workspace, we have internal crates that depend on others like this:

tools/crates/rome_js_parser/Cargo.toml

Lines 14 to 20 in 1837190

	rome_console = { version = "0.0.1", path = "../rome_console" }
	rome_diagnostics = { version = "0.0.1", path = "../rome_diagnostics" }
	rome_js_syntax = { version = "0.0.2", path = "../rome_js_syntax" }
	rome_js_factory = { version = "0.0.2", path = "../rome_js_factory" }
	rome_js_unicode_table = { version = "0.0.1", path = "../rome_js_unicode_table" }
	rome_rowan = { version = "0.0.1", path = "../rome_rowan" }
	rome_parser = { version = "0.0.1", path = "../rome_parser" }

These lines are repeated across all the Cargo.toml. This is not maintainable when we need to update the version numbers, for example.

We want to change this by doing the following:

• move all these definitions inside the main Cargo.toml, at the root of the workspace, below [workspace.dependencies]

[workspace.dependencies]
 rome_js_syntax = { version = "0.0.1", path = "./crates/rome_js_syntax" } 

• then, change all the occurrences of our internal rome_ creates in the various Cargo.toml, like this:

rome_js_syntax.workspace = true

[Boshen]

You may want to test your release script for this, cargo workspaces stopped working when I changed to this :-(

[ematipico]

You may want to test your release script for this, cargo workspaces stopped working when I changed to this :-(

Fortunately, as for now, crates are published manually, and we don't use cargo workspaces at the moment :)

[gautamprikshit1]

I would like to try it

[ematipico]

@gautamprikshit1 Thank you! Go ahead! Feel free to start with one crate or all of them. If there's something that's not clear, feel free to ask

[gautamprikshit1]

@ematipico I am having issues compiling it post changes.

[ematipico]

That's been implemented