Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Changed internal rome dependencies to workspace #4515

Closed

Conversation

gautamprikshit1
Copy link
Contributor

Fixes #4510

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: errors and diagnostics A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project configuration and loading labels May 20, 2023
@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ef91020
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/646859c8ee18aa0008f2c991

@ematipico
Copy link
Contributor

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

@Boshen
Copy link
Contributor

Boshen commented May 20, 2023

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

It's valid to specify default features for internal crates as well:

internal_crate1 = { version = "x.x.x", default-features = false, features = ["..."] }
internal_crate2 = { version = "x.x.x", default-features = true }

@gautamprikshit1
Copy link
Contributor Author

Didn't work

I believe some issues are caused by some of our crates that have [features]. As a starter could you try to refactor only the crates that don't have [features] in their Cargo.toml?

Didn't work same error

@ematipico
Copy link
Contributor

@gautamprikshit1 I strongly suggest applying the changes gradually, crate by crate. And maybe do a PR only with gradual changes as a starting point.

For example, I just tried to refactor rome_rowan, and it worked. From there, you could make a PR. Let's try this approach :)

@gautamprikshit1
Copy link
Contributor Author

I will close this PR and start over, Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: errors and diagnostics A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Use the workspace to define internal crate dependencies
3 participants