This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat: mark errors with "guessed" unknown nodes instead of errors #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
738331b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0c4f8ec.tools-8rn.pages.dev |
Test262 comparison coverage results on windows-latest
|
Test262 comparison coverage results on windows-latest
|
ematipico
force-pushed
the
feature/unknown-nodes-errors
branch
2 times, most recently
from
0f599c0
to
4bf12dd
Compare
ematipico
force-pushed
the
feature/unknown-nodes-errors
branch
from
15072f0
to
397e567
Compare
Test262 comparison coverage results on ubuntu-latest
|
ematipico
force-pushed
the
feature/unknown-nodes-errors
branch
2 times, most recently
from
24629d5
to
da8e59a
Compare
ematipico
force-pushed
the
feature/unknown-nodes-errors
branch
from
39523fe
to
e126fd3
Compare
This was referenced Nov 23, 2021
|
When/What's your plan for merging this PR? Are you planning to make all error recovery changes first? |
My plan is to remove the usage of There's one more PR (going to open it soon) and after that I think we can merge this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1759
This PR groups a number of other PRs that were already merged and reviewed. We removed the usage of
ERRORin places the parser can't recover and marks nodes asUnknown.Test Plan
Current CI