This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): ignore option of files config #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
nissy-dev
changed the title
nissy-dev
changed the title
nissy-dev
commented
Nov 8, 2022
nissy-dev
changed the title
ematipico
approved these changes
Nov 14, 2022
MichaReiser
approved these changes
Nov 15, 2022
| @@ -514,6 +514,17 @@ | |||
| "description": "The configuration of the filesystem", | |||
| "type": "object", | |||
| "properties": { | |||
| "ignore": { | |||
| "description": "A list of Unix shell style patterns. The formatter will ignore files/folders that will match these patterns.", | |||
There was a problem hiding this comment.
We need to update the description to make it clear that the ignore patterns are not formatter specific
ematipico
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related #3328
I implemented simple ignore option for files config.
Test Plan
I added some test cases for this ignore option.