This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): Respect formatter/linter enabled from configuration
#3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where `rome ci` ignored the `formatter.enabled` and `linter.disabled` configuration. The issue was that the CI defaulted to `true` when the `--formater/linter-enabled` options weren't specified. ## Test Plan The reason why the existing integration test didn't work is that Rome doesn't check the formatting for files that have lint/parse errors. I changed the integration test to a file that only has incorrect formatting.
✅ Deploy Preview for docs-rometools canceled.
|
leops
approved these changes
Nov 8, 2022
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 9, 2022
* upstream/main: fix(rome_js_analyze): Verify method name of React API calls (rome#3619) benchmark: Add pprettier and dprint to benchmark (rome#3597) feat(vscode): display the version of the language server in the status bar (rome#3616) fix(rome_cli): correctly account for diff diagnostics in the printed diagnostics count (rome#3595) fix(rome_cli): Respect formatter/linter `enabled` from configuration (rome#3591) Remove dead styles [website] Add scroll-padding-top
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
rome ciignored theformatter.enabledandlinter.disabledconfiguration. The issue was that the CI defaulted totruewhen the--formater/linter-enabledoptions weren't specified.Test Plan
The existing integration test didn't work because Rome doesn't check the formatting for files with lint/parse errors. I changed the integration test to a file that only has incorrect formatting.