This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): Verify method name of React API calls #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
## Summary The `is_react_call_api` in some situations didn't test if the method name is the tested for method name. For example, `is_react_call_api(..., "cloneElement")` returned true for `React.clone` or just `clone`. I fixed the same issue in `jsx_member_name_is_react_fragment` ## Test Plan I added some new tests veryfing that the logic correctly verifies the member name.
MichaReiser
force-pushed
the
fix/react-rules
branch
from
55f93e4
to
556ccff
Compare
leops
reviewed
Nov 9, 2022
crates/rome_js_analyze/tests/specs/a11y/noPositiveTabindex/reactCreateElementInvalid.js
Outdated
Show resolved
Hide resolved
leops
approved these changes
Nov 9, 2022
MichaReiser
changed the title
React symbols resolve to react moduleReact symbols resolve to react module
MichaReiser
changed the title
React symbols resolve to react module
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 9, 2022
* upstream/main: fix(rome_js_analyze): Verify method name of React API calls (rome#3619) benchmark: Add pprettier and dprint to benchmark (rome#3597) feat(vscode): display the version of the language server in the status bar (rome#3616) fix(rome_cli): correctly account for diff diagnostics in the printed diagnostics count (rome#3595) fix(rome_cli): Respect formatter/linter `enabled` from configuration (rome#3591) Remove dead styles [website] Add scroll-padding-top
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
is_react_call_apiin some situations didn't test if the method name is the tested for method name.For example,
is_react_call_api(..., "cloneElement")returned true forReact.cloneor justclone.I fixed the same issue in
jsx_member_name_is_react_fragmentCloses #3618
Test Plan
I added some new tests veryfing that the logic correctly verifies the member name.