This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): add $schema to configuration
#3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feature/json-schema-field
branch
from
bd6d6e4
to
8cdeaf4
Compare
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
leops
reviewed
Nov 15, 2022
MichaReiser
reviewed
Nov 16, 2022
ematipico
force-pushed
the
feature/json-schema-field
branch
from
8350777
to
22e4d57
Compare
ematipico
force-pushed
the
feature/json-schema-field
branch
from
22e4d57
to
cd23764
Compare
ematipico
force-pushed
the
feature/json-schema-field
branch
from
6dc0bda
to
92be9a2
Compare
leops
approved these changes
Nov 18, 2022
| @@ -0,0 +1,1230 @@ | |||
| { | |||
There was a problem hiding this comment.
We should add this file (and its copy under editors/vscode) to the list of auto-generated files in .gitattributes
| @@ -226,6 +231,16 @@ pub fn create_config( | |||
| } | |||
| })?; | |||
|
|
|||
| // we now check if rome is installed inside `node_modules` and if so, we | |||
| let schema_path = PathBuf::from("./") | |||
There was a problem hiding this comment.
Nit: Use Path::new("./node_modules/rome/configuration_schema.json") to avoid allocating a PathBuf object (and also avoid using platform-specific path separators, since I think join would use \ on Windows and cause the snapshot tests to fail)
ematipico
force-pushed
the
feature/json-schema-field
branch
from
9a0c368
to
99b92b5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3690
$schemaproperty to the configurationcodegen-configurationandcodegen-schemaaliases to store the first paragraph of the documentation of the rulesromepackage to publish a new file calledconfiguration_schema.jsonDefaultimplementation ofConfiguration, with the$schemavalue that points to./node_modules/rome/configuration_schema.json.This change is very biased. I thought that it could be a nice DX improvement to have it as part of the
rome initcommand. The path is hard coded, I checked on the internet and it seems that all local paths use unix paths, it don't seem to be OS dependent.Test Plan
I updated the existing CLI tests. The CI should pass for code generated files.