This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): handle default clause in useSingleCaseStetement
#4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
leops
reviewed
Dec 19, 2022
crates/rome_js_analyze/src/analyzers/style/use_single_case_statement.rs
Outdated
Show resolved
Hide resolved
Conaclos
requested review from
leops
and removed request for
xunilrj and
ematipico
|
This PR is stale because it has been open 14 days with no activity. |
ematipico
approved these changes
Feb 15, 2023
crates/rome_js_analyze/src/analyzers/style/use_single_case_statement.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4068.
I also updated the diagnostic for better consistency with other rules.
By the way, the rule should certainly be renamed to
useSingleSwitchClauseStatement.Unfortunately, this is a stable rule.
I personally could rather deprecate the rule, once
noSwitchDeclarationsbecomes merged or stable.Test Plan
New Unit test for
defaultswitch clauses.Documentation