Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

tests(rome_js_formatter): update prettier snapshots #4234

Merged
merged 1 commit into from
Apr 16, 2023
Merged

tests(rome_js_formatter): update prettier snapshots #4234

merged 1 commit into from
Apr 16, 2023

Conversation

Conaclos
Copy link
Contributor

Summary

Update prettier snapshots.

Test Plan

No change.

Documentation

No change.

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e4e3274
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/643c7237cc9f52000858f73e
😎 Deploy Preview https://deploy-preview-4234--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it once the snapshots are updated

@Conaclos
Copy link
Contributor Author

They are updated. I just got an error on testing. I have to take some time to understand what's going on.

@nissy-dev
Copy link
Contributor

@Conaclos Can we merge this PR?

@Conaclos
Copy link
Contributor Author

@Conaclos Can we merge this PR?

Not yet. #4255 is still blocking this PR.
By the way, I could appreciate some help on #4255.

@nissy-dev
Copy link
Contributor

By the way, I could appreciate some help on #4255.

OK 👍 I'll try to check #4255

#4255 is still blocking this PR.

I think it is enough to fix some regressions like #4255 after merging this PR.

Updating the Prettier version is helpful when implementing a formatter for new syntax. Personally, I would like to check the formatting differences of const type parameters (#4275), and it is also advisable to work on the formatting results of the ongoing decorator based on the latest Prettier results.

@denbezrukov
Copy link
Contributor

We can delete snapshots with switch cases and comments to merge updated prettier snapshots and try to fix it latter:)

@Conaclos
Copy link
Contributor Author

We can delete snapshots with switch cases and comments to merge updated prettier snapshots and try to fix it latter:)

Thanks for the input. I will update this PR and will merge it.

…4376)

fix(vscode): Text duplication when using VSCode git utilities #4338
@github-actions github-actions bot added the A-Formatter Area: formatter label Apr 16, 2023
@Conaclos Conaclos merged commit 309d186 into rome:main Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants