This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noUselessCatch #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Conaclos
suggested changes
Feb 25, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
|
LGTM. Once the requested change are made, we can merge :) |
|
Hold on, i need update the test snapshot & docs |
done~~ |
ematipico
suggested changes
Feb 25, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_useless_catch.rs
Outdated
Show resolved
Hide resolved
Conaclos
approved these changes
Feb 25, 2023
GiveMe-A-Name
force-pushed
the
feat/no-unless-catch
branch
2 times, most recently
from
41031c9
to
62c2d3e
Compare
ematipico
approved these changes
Feb 25, 2023
Co-authored-by: Victorien ELVINGER <victorien@elvinger.fr>
Co-authored-by: Victorien ELVINGER <victorien@elvinger.fr>
GiveMe-A-Name
force-pushed
the
feat/no-unless-catch
branch
from
62c2d3e
to
1ae17c1
Compare
Done, it was re-based. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add more lint rule: no_useless_catch
The rule reference from Eslint: no-useless-catch
Test Plan
I added two new test cases.
Documentation