Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noNoninteractiveTabindex #4312

Merged
merged 4 commits into from
Mar 31, 2023
Merged

feat(rome_js_analyze): noNoninteractiveTabindex #4312

merged 4 commits into from
Mar 31, 2023

Conversation

unvalley
Copy link
Contributor

@unvalley unvalley commented Mar 19, 2023

Summary

Closes #3817

Test Plan

cargo test -p rome_js_analyze -- no_noninteractive_tabindex

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Mar 19, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e2f79c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6426ee2b6cb73c00083a9394

@github-actions github-actions bot added A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading labels Mar 19, 2023
@unvalley unvalley marked this pull request as ready for review March 24, 2023 16:13
feat: implement lint rule

refactor: rule logic

chore: apply codegen

fix: for role sensitive elements

chore: apply codegen

chore: format

test: use prepared test cases

chore: update eslint equivalent

chore: update lint rule doc on website

chore: remove waste space

chore: fix comment
@ematipico ematipico merged commit 22f3cb4 into rome:main Mar 31, 2023
@unvalley unvalley deleted the no-noninteractive-tabindex branch April 2, 2023 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noNoninteractiveTabindex
2 participants