This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_anaylze): introduce StaticValue enum for checking value of the JSX attributes or JS expressions #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nissy-dev
changed the title
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
nissy-dev
changed the title
nissy-dev
changed the title
|
@MichaReiser This PR is based on your comments in #4073, so I would appreciate if you could review. |
ematipico
suggested changes
Apr 2, 2023
CHANGELOG.md
Outdated
|
|
||
| #### Other changes | ||
|
|
||
| - Refactor common logic for checking value of the JSX attributes or JS expressions [#4073](https://github.com/rome/tools/pull/4073) |
There was a problem hiding this comment.
We don't want to document internal changes that don't affect the users. From this PR, the only change for users is the fact that we fixed a case inside the useNumericLiterals rule
There was a problem hiding this comment.
I reverted the differences in CHANGELOG.md.
| self.text() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We should document this API and add a doctest, like we do for other public APIs exposed by this crate.
There was a problem hiding this comment.
I added doctests for StaticValue and QuotedString.
This reverts commit 64735f4.
ematipico
approved these changes
Apr 7, 2023
This was referenced Apr 15, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces common logic for checking expression values based on #4073 and discussion. This is useful when implementing some aria rules that checks value of the JSX attributes.
After merge in this PR, I will refactor much more in the current codebases using this methods.
Test Plan
I need to keep the current tests passed. I updated
useNumericLiterals/invalid.js.snapbecause the previous code didn't handle empty template string correctly.Changelog
Documentation