Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): add more tests and docs for a11y rules through refactoring #4377

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

I added more tests and docs for a11y rules through refactoring based on #4342

Test Plan

Changelog

This is internal refactoring, so I don't update the CHAGELOG.md

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Apr 15, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 51eee29
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/643a495b11f87e00085dc45d
😎 Deploy Preview https://deploy-preview-4377--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser labels Apr 15, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48647 48647 0
Passed 47568 47568 0
Failed 1079 1079 0
Panics 0 0 0
Coverage 97.78% 97.78% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6093 6093 0
Passed 1783 1783 0
Failed 4310 4310 0
Panics 0 0 0
Coverage 29.26% 29.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 568 568 0
Failed 71 71 0
Panics 0 0 0
Coverage 88.89% 88.89% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16740 16740 0
Passed 12803 12803 0
Failed 3937 3937 0
Panics 0 0 0
Coverage 76.48% 76.48% 0.00%

@github-actions github-actions bot added the A-Project Area: project configuration and loading label Apr 15, 2023
@nissy-dev nissy-dev marked this pull request as ready for review April 15, 2023 08:52
@ematipico ematipico merged commit 75af95e into main Apr 16, 2023
@ematipico ematipico deleted the refactor/lint-rules-1 branch April 16, 2023 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Parser Area: parser A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants