This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 662
fix(rome_js_analyze): useShorthandArrayType
should handle nested ReadonlyArray and not report to TsObjectType
#4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
useShorthandArrayType
to handle nested ReadonlyArray
ematipico
reviewed
Apr 7, 2023
got it ill make seperate issue |
useShorthandArrayType
to handle nested ReadonlyArrayuseShorthandArrayType
should handle nested ReadonlyArray and not report to TsObjectType
useShorthandArrayType
should handle nested ReadonlyArray and not report to TsObjectTypeuseShorthandArrayType
should handle nested ReadonlyArray and not report to TsObjectType
ematipico
approved these changes
Apr 11, 2023
@unvalley this PR requires a changelog line, could you please add it? |
…Array chore: comment docs: lint rule document chore: docs
@ematipico I updated it. |
ematipico
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4349 #4361
This pr adds modification for nested
ReadonlyArray
(#4349 ) and reduce false positive (#4361 ).Currently, our
useShorthandArrayType
follows typescript-eslint/array-type (array-simple option).And the rule should not report
TsObjectType
in a typeArray
orReadonlyArray
.Example
Test Plan
cargo test -p rome_js_analyze -- use_shorthand_array_type
Changelog
[ ] The PR requires a changelog lineDocumentation
[ ] The PR requires documentation[ ] I will create a new PR to update the documentationI updated lint rule doc a bit (describes typescript-eslint rule equivalent).