This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fear(rome_js_analyze): useGroupedTypeImport #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for docs-rometools failed.Built without sensitive environment variables
|
github-actions
bot
added
A-Diagnostic
|
Note: in my opinion the action is a bit dirty. However, I do not find another way to do that properly: we cannot directly apply mutation on every specifier since one of their ancestor has to be mutated. |
ematipico
reviewed
Apr 27, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_import_type_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_import_type_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_import_type_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/nursery/noImportTypeSideEffects/valid.ts
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_import_type_side_effects.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_import_type_side_effects.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Apr 27, 2023
Conaclos
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements
no-import-type-side-effects.I first named the rule
useFactorizedTypeImports, and so finally come back tonoImportTypeSideEffectsfor ease of discovering.EDIT: renamed to
useGroupedTypeImport.Test Plan
Eslint test included.
Changelog
Documentation