This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): useSimpleNumberKeys #4457 handle shortand/spread object props #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d object props
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
The Ci seems to encounter some issues... |
Have you rebased your branch? I believe I fixed that issue |
|
Fyi https://github.com/rome/tools/blob/main/.github/workflows/pull_request.yml#L80 You want to change this line to |
ematipico
approved these changes
May 11, 2023
|
@ematipico |
|
You can commit the change of the workflow in this PR! I don't mind |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4457
Test Plan
Regression test and new tests included.
Changelog
Documentation