fix(rome_js_analyze): Files with fn(() => (aborted = true)); cause -entered unreachable code - when --apply-unsafe #4464

[denbezrukov]

Summary

Fix #4464

We have the noAssignInExpressions rule.

tools/crates/rome_js_analyze/src/analyzers/suspicious/no_assign_in_expressions.rs

Lines 107 to 125 in 22ce6c6

	fn action(ctx: &RuleContext<Self>, _: &Self::State) -> Option<JsRuleAction> {
	let assign = ctx.query();
	let op = assign.operator().ok()?;
	if let JsAssignmentOperator::Assign = op {
	let operator_token = assign.operator_token().ok()?;
	let new_operator_token = make::token(JsSyntaxKind::EQ3);
	let mut mutation = ctx.root().begin();
	mutation.replace_token(operator_token, new_operator_token);
	Some(JsRuleAction {
	mutation,
	applicability: Applicability::MaybeIncorrect,
	category: ActionCategory::QuickFix,
	message: markup!("Did you mean '==='?").to_owned(),
	})
	} else {
	None
	}
	}
	}

We replace the token here with ===. However, the node remains a JsAssignmentExpression, and the subsequent noSelfAssign rule tries to retrieve the operator from the JsAssignmentExpression. This causes an issue because the node now contains ===.

I guess that the solution is to convert JsAssignmentExpression into JsBinaryExpression in the noAssignInExpressions rule.

Test Plan

cargo test

Changelog

• The PR requires a changelog line

Documentation

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools canceled.

Name	Link
🔨 Latest commit	77d9e64
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/64611af4498ee80007cd9661

[Conaclos]

LGTM