Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix: benchmark tooling failing calling node modules bin dir directly #4474

Merged
merged 1 commit into from
May 15, 2023

Conversation

connorjburton
Copy link
Contributor

Summary

The benchmarking tool was not working on Windows or the rust docker image. This was due to calling the node_modules .bin directory directly. Which should be avoided. I did try using npx however as the child process that runs hyperfine is ran in the working directory of the cloned repositories that did not work as anticipated.

Test Plan

N/A

Changelog

I don't believe this requires a changelog entry

  • The PR requires a changelog line

Documentation

This is a transparent fix and the documentation for the benchmark tool should not need updating.

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9981723
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64610e04c3ba7b0008d9916e

@Conaclos
Copy link
Contributor

Thanks!

@Conaclos Conaclos merged commit 362a39d into rome:main May 15, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants