This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat: Add noUselessTypeConstraint
#4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
A-Diagnostic
ematipico
reviewed
May 16, 2023
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Conaclos
reviewed
May 16, 2023
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Victorien ELVINGER <victorien@elvinger.fr>
|
Thank you for your time! I tried to address the stuff in the review. This PR should probably be squashed if it will be merged. |
No worry, we always squash the PRs :) By the way, could you rebase on main in order to resolve the conflicts? |
|
Done (+ resolve formatting issues) |
ematipico
approved these changes
May 17, 2023
|
There are still some errors: it seems you have to run just |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm relatively novel to rust and the rome internals. Please don't hesitate to state enhancements. I'd like to learn. :)
Also, feel free to push directly into my repository and/or close this PR if it doesn't fit.
Resolves #4480
Test Plan
Uset test:
Changelog
Documentation
(in case that an update is needed, please comment)