Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_service): correctly load recommended rules #4490

Merged
merged 1 commit into from May 17, 2023

Conversation

ematipico
Copy link
Contributor

Summary

Closes #4479 and addresses #4488

Test Plan

I used the code provided by #4488 because using nursery rules is too brittle.

I created a new test cases

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@ematipico ematipico requested a review from Conaclos May 16, 2023 14:16
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit e782da1
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6464b155ff108f000820a3c2

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling labels May 16, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47796 47796 0
Failed 1067 1067 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1763 1763 0
Failed 4449 4449 0
Panics 0 0 0
Coverage 28.38% 28.38% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13127 13127 0
Failed 4097 4097 0
Panics 0 0 0
Coverage 76.21% 76.21% 0.00%

@ematipico ematipico merged commit 76aff9f into main May 17, 2023
18 checks passed
@ematipico ematipico deleted the fix/rule-configuration branch May 17, 2023 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Enabling one nursery rule causes all other nursery rules to be enabled
3 participants