Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): allow nested func declarations in esm #4500

Merged
merged 1 commit into from
May 17, 2023
Merged

fix(rome_js_analyze): allow nested func declarations in esm #4500

merged 1 commit into from
May 17, 2023

Conversation

Conaclos
Copy link
Contributor

Summary

Fix #4492

Test Plan

New tests included.

Changelog

updated

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@Conaclos Conaclos requested a review from ematipico May 17, 2023 13:30
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 57d1bf4
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6464d6e168ad18000863ac6e
😎 Deploy Preview https://deploy-preview-4500--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added A-Linter Area: linter A-Project Area: project configuration and loading labels May 17, 2023
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! I love that we can catch more cases as we push more features in our analyzer :)

@Conaclos Conaclos merged commit 55f062d into rome:main May 17, 2023
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 noInnerDeclarations incorrectly reports on functions in esm/strict mode
2 participants