This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 666
Workspace internal deps #4525
Merged
ematipico
merged 34 commits into
rome:main
from
gautamprikshit1:workspace_internal_deps
May 26, 2023
Merged
Workspace internal deps #4525
ematipico
merged 34 commits into
rome:main
from
gautamprikshit1:workspace_internal_deps
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
…rkspace dependencies
ematipico
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to keep the version
in our internal crates
rome_markup = { version = "0.0.1", path = "../rome_markup" } | ||
rome_markup = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some crates have the version because they are published on crates.io.
We must keep the version in the main Cargo.toml
Could you please restore the template and fill it, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-CLI
Area: CLI
A-Core
Area: core
A-Diagnostic
Area: errors and diagnostics
A-Formatter
Area: formatter
A-Linter
Area: linter
A-LSP
Area: language server protocol
A-Parser
Area: parser
A-Project
Area: project configuration and loading
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved internal dependencies to the workspace.
Fixes #4515
Test Plan
Changelog
Documentation