Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): add options to noRestrictedGlobals #4723

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ematipico
Copy link
Contributor

Summary

Closes #4628

@arendjr Fixed a problem in the document with the rule you recently implemented in this PR. When documenting INVALID cases, the snippet must raise one single diagnostic; otherwise, the documentation generated isn't correct. (I wonder why the script doesn't panic anymore, it used to).

Test Plan

Added a new test case

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit dcbba9b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64be4474a8a74e00085d4f78

@github-actions github-actions bot added A-Website Area: website and documentation A-Linter Area: linter L-JavaScript Langauge: JavaScript A-Tooling Area: our own build, development, and release tooling A-Project Area: project configuration and loading labels Jul 23, 2023
@ematipico ematipico force-pushed the feat/restricted-globals branch 2 times, most recently from 605b66a to ed7ffe9 Compare July 23, 2023 16:46
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47810 47810 0
Failed 1053 1053 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1764 1764 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 28.40% 28.40% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13121 13121 0
Failed 4103 4103 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@github-actions github-actions bot added A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics labels Jul 23, 2023
@arendjr
Copy link
Contributor

arendjr commented Jul 24, 2023

@ematipico Got it, thanks for the heads-up!

@ematipico ematipico merged commit 1dcd62b into main Jul 24, 2023
18 checks passed
@ematipico ematipico deleted the feat/restricted-globals branch July 24, 2023 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling A-Website Area: website and documentation L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 noRestrictedGlobals rule doesn't allow to specify restricted globals
2 participants